#dominoforever | Product Ideas Portal

 

Welcome to the #dominoforever Product Ideas Forum! The place where you can submit product ideas and enhancement request. We encourage you to participate by voting on, commenting on, and creating new ideas. All new ideas will be evaluated by HCL Product Management & Engineering teams, and the next steps will be communicated. While not all submitted ideas will be executed upon, community feedback will play a key role in influencing which ideas are and when they will be implemented.

For more information and upcoming events around #dominoforever, please visit our Destination Domino Page

Support theme names that are not starting with the prefix Bootstrap4

Extending the "Bootstrap4" theme causes some icons to use Glyphicon classes (which don't work) instead of the Font Awesome ones intended for use with Bootstrap 4


At present, to override the Bootstrap4 theme there are few points that needs to be followed:

1. Extend "Bootstrap4" theme (Note: Theme name to extend is case sensitive).

<theme extends="Bootstrap4">

2. While generating the custom theme it should start with "Bootstrap4%".


  • Guest
  • Jun 2 2021
  • Needs review
  • Attach files
  • Guest commented
    2 Jun 02:33pm

    The bug here comes from two layered problems:


    1) The general choice to base renderer behavior on the specific string name of the root theme in the "extends" chain

    2) A bug in the `Resources` utility class that uses the current theme name as opposed to actually finding the root theme


    This can also potentially (based on threading) manifest in an app directly using "Bootstrap4" (or a theme named starting with "Bootstrap4") if another app on the server extends any HCL-provided Bootstrap theme but uses a theme that doesn't start with "Bootstrap4". Or vice versa, since the trouble is the same.